Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] add 'auto' value for importance_type param in plotting #4570

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

StrikerRUS
Copy link
Collaborator

Respect importance_type attribute of LGBMModel in plot_importance().

Marking this as breaking, but I don't think this change will actually affect many users. Only those will be affected who for some reason specify LGBMModel(importance_type="gain") and leave default value (importance_type="split") in plot_importance().

@StrikerRUS StrikerRUS force-pushed the default_importance_type branch 2 times, most recently from c6123f3 to c174666 Compare August 29, 2021 03:08
@StrikerRUS StrikerRUS force-pushed the default_importance_type branch from c174666 to 569fcc8 Compare August 29, 2021 03:26
@StrikerRUS StrikerRUS marked this pull request as ready for review August 29, 2021 12:33
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok to me, and I agree this is the type of "breaking" change that is ok for a minor release

@jameslamb jameslamb merged commit 3942126 into master Sep 1, 2021
@jameslamb jameslamb deleted the default_importance_type branch September 1, 2021 01:24
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants